Support for custom evaluators #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
shaahji
force-pushed
the
shaahji/evalreg
branch
from
f00da81 to
3905e74
Compare
xiaoyu-work
reviewed
Aug 6, 2024
|
Overall this looks good to me. Can you please fix the tests and Github warnings? Can you also add a documentation about how to use custom evaluators for advanced users? |
shaahji
force-pushed
the
shaahji/evalreg
branch
4 times, most recently
from
1bbaa9d to
cc73974
Compare
* Move evaluation registration out of OliveEvaluator into its own class * Evaluators are registered using both the Framework and the class name * Add "type", "type_args", "user_script" and "script_dir" to OliveEvaluationConfig to support user specific custom implementation * Remove some dead code
shaahji
force-pushed
the
shaahji/evalreg
branch
from
cc73974 to
414e4a1
Compare
jambayk
reviewed
Aug 8, 2024
jambayk
reviewed
Aug 8, 2024
jambayk
reviewed
Aug 8, 2024
jambayk
approved these changes
Aug 8, 2024
DavitGrigoryan132
pushed a commit
to DavitGrigoryan132/Olive
that referenced
this pull request
Aug 14, 2024
## Support for custom evaluators * Move evaluation registration out of OliveEvaluator into its own class * Evaluators are registered using both the Framework and the class name * Add "type", "type_args", "user_script" and "script_dir" to OliveEvaluationConfig to support user specific custom implementation * Remove some dead code ## Checklist before requesting a review - [x] Add unit tests for this change. - [x] Make sure all tests can pass. - [ ] Update documents if necessary. - [x] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for custom evaluators
Checklist before requesting a review
lintrunner -a(Optional) Issue link