-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes potential duplicate operation ids of navigation property paths with overloaded composable functions #597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion. Otherwise looks good from my end.
I believe to fix the sonar coverage reporting you will need to update this line to end with coverage.net8.0.opencover.xml
as the net7.0 coverage artifact no longer exists...
dotnet tool run dotnet-sonarscanner begin /k:"microsoft_OpenAPI.NET.OData" /o:"microsoft" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.cs.opencover.reportsPaths="test/**/coverage.net7.0.opencover.xml" |
Co-authored-by: Andrew Omondi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit surprised we don't have to refresh the integration tests with those changes. But thanks for the quick turnaround on this one.
@andrueastman thanks for the suggestion, quickly put #598 together |
|
…with overloaded composable functions (#597) * Fixes generation of navigation property op ids with overloaded composable fxns * Adds validation unit test * Updates release note * chore: adds string comparison Co-authored-by: Andrew Omondi <[email protected]> --------- Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: Andrew Omondi <[email protected]>
…with overloaded composable functions (#597)
Fixes #596