Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes potential duplicate operation ids of navigation property paths with overloaded composable functions #597

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

irvinesunday
Copy link
Contributor

Fixes #596

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion. Otherwise looks good from my end.

I believe to fix the sonar coverage reporting you will need to update this line to end with coverage.net8.0.opencover.xml as the net7.0 coverage artifact no longer exists...

dotnet tool run dotnet-sonarscanner begin /k:"microsoft_OpenAPI.NET.OData" /o:"microsoft" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.cs.opencover.reportsPaths="test/**/coverage.net7.0.opencover.xml"

Co-authored-by: Andrew Omondi <[email protected]>
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised we don't have to refresh the integration tests with those changes. But thanks for the quick turnaround on this one.

@baywet
Copy link
Member

baywet commented Oct 17, 2024

@andrueastman thanks for the suggestion, quickly put #598 together

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@irvinesunday irvinesunday merged commit a464bed into master Oct 17, 2024
12 of 13 checks passed
@irvinesunday irvinesunday deleted the is/composable-fxns-nav-props-fix branch October 17, 2024 14:26
andrueastman added a commit that referenced this pull request Jan 15, 2025
…with overloaded composable functions (#597)

* Fixes generation of navigation property op ids with overloaded composable fxns

* Adds validation unit test

* Updates release note

* chore: adds string comparison

Co-authored-by: Andrew Omondi <[email protected]>

---------

Co-authored-by: Vincent Biret <[email protected]>
Co-authored-by: Andrew Omondi <[email protected]>
andrueastman added a commit that referenced this pull request Jan 15, 2025
@andrueastman andrueastman mentioned this pull request Jan 15, 2025
baywet added a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remaining duplicate operation Ids for navigation properties on composable functions
3 participants