Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 refresh #1631

Merged
merged 16 commits into from
Apr 17, 2024

Merge pull request #1630 from microsoft/baywet-patch-1

e308430
Select commit
Loading
Failed to load commit list.
Merged

v2 refresh #1631

Merge pull request #1630 from microsoft/baywet-patch-1
e308430
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Apr 17, 2024 in 1s

6 new alerts

New alerts in code changed by this pull request

  • 2 warnings
  • 4 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 96 in src/Microsoft.OpenApi/Models/OpenApiComponents.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 120 in src/Microsoft.OpenApi/Models/OpenApiHeader.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check notice on line 16 in src/Microsoft.OpenApi/Expressions/CompositeExpression.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field 'expressionPattern' can be 'readonly'.

Check notice on line 31 in src/Microsoft.OpenApi/Validations/Rules/OpenApiContactRules.cs

See this annotation in the file changed.

Code scanning / CodeQL

Nested 'if' statements can be combined Note

These 'if' statements can be combined.

Check notice on line 25 in src/Microsoft.OpenApi.Hidi/OpenApiSpecVersionHelper.cs

See this annotation in the file changed.

Code scanning / CodeQL

Nested 'if' statements can be combined Note

These 'if' statements can be combined.

Check notice on line 77 in src/Microsoft.OpenApi/Validations/Rules/OpenApiPathsRules.cs

See this annotation in the file changed.

Code scanning / CodeQL

String concatenation in loop Note

String concatenation in loop: use 'StringBuilder'.