-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize variable presentation using tools options page #6337
Conversation
what r the drop down options? just show/hide? would that work with a checkbox? |
Python/Product/PythonTools/PythonTools/Debugger/DebugAdapter/DebugAdapterLauncher.cs
Outdated
Show resolved
Hide resolved
Python/Product/PythonTools/PythonTools/Options/PythonDebuggingOptionsControl.cs
Show resolved
Hide resolved
Looks like there are some minor formatting issues (curly braces on separate lines etc) - might need to reformat the affected docs to match existing style. |
@judej @bschnurr The default presentation style seems to be "group" in vscode, but I made the default in VS to be "inline" to match what normal VS variables look like. Would you prefer that we match vscode and use "group" ? Also Bill, can you please send me your point of contact for VS UI approvals? Thanks! |
I'd recommend group - much easier to read and all the vars are available if needed |
Python/Product/PythonTools/PythonTools/Options/PythonDebuggingOptionsControl.cs
Show resolved
Hide resolved
I just had a very informative meeting with the Visual Studio UX Board. They shared lots of feedback around patterns to avoid, as well as style and accessibility guidelines. They will be creating some tickets under the |
Will you be submitting mocks first? |
I'm not 100% sure if the string needs to be in Strings.resx to to localized or not. Or if can be in any resx. I guess we will find out soon |
Kudos, SonarCloud Quality Gate passed! |
Everything seems to be working just fine, and I implemented all the UXBoard suggestions, so I'm going to merge this in and insert into VS. |
ok |
Fixes #6334
Fixes #6342
Definitely open to UI changes or approvals if we need, I'm not familiar with the process.
Here's what it looks like:
It also fixes the immediate window from showing too much information: