Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize variable presentation using tools options page #6337

Merged
merged 6 commits into from
Jan 21, 2021
Merged

Customize variable presentation using tools options page #6337

merged 6 commits into from
Jan 21, 2021

Conversation

AdamYoblick
Copy link
Member

@AdamYoblick AdamYoblick commented Jan 12, 2021

Fixes #6334
Fixes #6342

Definitely open to UI changes or approvals if we need, I'm not familiar with the process.

Here's what it looks like:

image

image

It also fixes the immediate window from showing too much information:

image

@AdamYoblick AdamYoblick requested review from bschnurr and judej January 12, 2021 00:31
@bschnurr
Copy link
Member

what r the drop down options? just show/hide? would that work with a checkbox?

@AdamYoblick
Copy link
Member Author

Ah sorry, I didn't show the values. Checkbox won't work, there are three possible:

image

@int19h
Copy link
Contributor

int19h commented Jan 12, 2021

Looks like there are some minor formatting issues (curly braces on separate lines etc) - might need to reformat the affected docs to match existing style.

@AdamYoblick
Copy link
Member Author

@judej @bschnurr The default presentation style seems to be "group" in vscode, but I made the default in VS to be "inline" to match what normal VS variables look like. Would you prefer that we match vscode and use "group" ?

Also Bill, can you please send me your point of contact for VS UI approvals?

Thanks!

@judej
Copy link
Contributor

judej commented Jan 12, 2021

I'd recommend group - much easier to read and all the vars are available if needed

@AdamYoblick
Copy link
Member Author

AdamYoblick commented Jan 20, 2021

I just had a very informative meeting with the Visual Studio UX Board. They shared lots of feedback around patterns to avoid, as well as style and accessibility guidelines. They will be creating some tickets under the DevDiv\Python and AI Tools\Python\VS IDE area path on dev.azure.com/devdiv/DevDiv that I will address before merging this work in. None of the suggestions will change the functionality, they all relate to how the options are presented to the user.

@judej
Copy link
Contributor

judej commented Jan 20, 2021

Will you be submitting mocks first?

@AdamYoblick
Copy link
Member Author

They didn't like the groupbox and they thought that "Variable Presentation" was a little vague. Also some minor casing, tab order, etc...

It's going to look something like this:

image

@bschnurr
Copy link
Member

bschnurr commented Jan 20, 2021

I'm not 100% sure if the string needs to be in Strings.resx to to localized or not. Or if can be in any resx.

I guess we will find out soon

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AdamYoblick
Copy link
Member Author

Everything seems to be working just fine, and I implemented all the UXBoard suggestions, so I'm going to merge this in and insert into VS.

@AdamYoblick AdamYoblick merged commit b5e38ce into microsoft:master Jan 21, 2021
@bschnurr
Copy link
Member

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants