Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up User-defined type related parser flag #2697

Merged
merged 12 commits into from
Oct 22, 2024
Merged

Clean up User-defined type related parser flag #2697

merged 12 commits into from
Oct 22, 2024

Conversation

adithyaselv
Copy link
Contributor

@adithyaselv adithyaselv commented Oct 16, 2024 •
edited
Loading

  • Remove AllowParseAsTypeLiteral, AllowTypeLiteral parser flag.
  • AsType, IsType and ParseJSON overloads are part of Builtin Functions
  • Add constant for Type Keyword.
  • Add type arg functions to Built-in
  • Refactor test

@adithyaselv adithyaselv changed the title [Draft] Clean up User-defined type parser flag [Draft] Clean up User-defined type related parser flag Oct 16, 2024
@LucGenetier
Copy link
Contributor

Public API changes:
❌CP0002 M:Microsoft.PowerFx.DefinitionsCheckResult.#ctor

@LucGenetier
Copy link
Contributor

Public API changes:
❌CP0002 M:Microsoft.PowerFx.DefinitionsCheckResult.#ctor

@LucGenetier
Copy link
Contributor

Public API changes:
❌CP0002 M:Microsoft.PowerFx.DefinitionsCheckResult.#ctor

@adithyaselv adithyaselv changed the title [Draft] Clean up User-defined type related parser flag Clean up User-defined type related parser flag Oct 17, 2024
@adithyaselv adithyaselv marked this pull request as ready for review October 17, 2024 21:58
@adithyaselv adithyaselv requested a review from a team as a code owner October 17, 2024 21:58
@LucGenetier
Copy link
Contributor

Public API changes:
❌CP0002 M:Microsoft.PowerFx.DefinitionsCheckResult.#ctor

@LucGenetier
Copy link
Contributor

Public API changes:
❌CP0002 M:Microsoft.PowerFx.DefinitionsCheckResult.#ctor

@adithyaselv adithyaselv added the Breaking Internals Breaking change - may require a PA Client update. label Oct 17, 2024
@LucGenetier
Copy link
Contributor

✅ No public API change.

@LucGenetier
Copy link
Contributor

✅ No public API change.

@LucGenetier
Copy link
Contributor

✅ No public API change.

CarlosFigueiraMSFT
CarlosFigueiraMSFT approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@CarlosFigueiraMSFT CarlosFigueiraMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@LucGenetier
Copy link
Contributor

✅ No public API change.

@adithyaselv adithyaselv merged commit f473c48 into main Oct 22, 2024
4 checks passed
@adithyaselv adithyaselv deleted the adithyase/parser-flag-cleanup branch November 22, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeStall MikeStall MikeStall left review comments

@CarlosFigueiraMSFT CarlosFigueiraMSFT CarlosFigueiraMSFT approved these changes

Assignees
No one assigned
Labels
Breaking Internals Breaking change - may require a PA Client update.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adithyaselv @LucGenetier @MikeStall @CarlosFigueiraMSFT