Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup namespace for publics. #361

Merged
merged 9 commits into from
Apr 29, 2022
Merged

Fixup namespace for publics. #361

merged 9 commits into from
Apr 29, 2022

Conversation

MikeStall
Copy link
Contributor

Apply renames to publics. See PublicSurfaceTest for principles:

        // The goal for public namespaces is to make the SDK easy for the consumer. 
        // Namespace principles for public classes:            // 
        // - prefer fewer namespaces. See C# for example: https://docs.microsoft.com/en-us/dotnet/api/microsoft.codeanalysis
        // - For easy discovery, but Engine in "Microsoft.PowerFx".
        // - For sub areas with many related classes, cluster into a single subnamespace.
        // - Avoid nesting more than 1 level deep

This tries to just change using and namespaces - just update public surface area and minimize churn.

@coveralls
Copy link

coveralls commented Apr 29, 2022

lesaltzm
lesaltzm previously approved these changes Apr 29, 2022
@MikeStall MikeStall merged commit 749ba83 into main Apr 29, 2022
@lesaltzm lesaltzm deleted the jmstall/rename1 branch July 18, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants