Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Installer] - Explore alternatives to kicking explorer for shell regs #2730

Closed
crutkas opened this issue May 6, 2020 · 3 comments
Closed

[Installer] - Explore alternatives to kicking explorer for shell regs #2730

crutkas opened this issue May 6, 2020 · 3 comments
Assignees
@vldmr11080
Labels
Area-Setup/Install Refers to installation mechanism Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Stability Release

Comments

@crutkas
Copy link
Member

crutkas commented May 6, 2020

currently to add / remove items in shell, we have to kick explorer. After this happens, PT can then enable / disable for them showing up.

We should see how we can do some alternative methods
@crutkas crutkas added the Area-Setup/Install Refers to installation mechanism label May 6, 2020
@crutkas crutkas added this to the v1.0 Release milestone May 6, 2020
@htcfreek
Copy link
Collaborator

htcfreek commented May 6, 2020

We could use the SHChangeNotify event to inform explorer.exe about the change.
https://docs.microsoft.com/en-us/windows/win32/shell/reg-shell-exts

The problem will be upgrading/deleting the DLLs. Because explorer.exe has opened handles on it. Maybe unregister the dll helps or the Windows Installer has an builtin feature.

@enricogior enricogior mentioned this issue May 6, 2020
Closed
@enricogior enricogior mentioned this issue May 14, 2020
Closed
@crutkas crutkas mentioned this issue May 22, 2020
Closed
@codehz
Copy link

codehz commented May 23, 2020 •
edited
Loading

currently to add / remove items in shell, we have to kick explorer. After this happens, PT can then enable / disable for them showing up.

It is actually keep crashing (and restarting) the explorer until logout and re-login in my machine in 0.18.0/0.18.1

This was referenced May 23, 2020
Closed
Closed
Closed
This was referenced Jun 5, 2020
Closed
Closed
@vldmr11080 vldmr11080 self-assigned this Jun 8, 2020
@vldmr11080 vldmr11080 added the Status-In progress This issue or work-item is under development label Jun 8, 2020
@vldmr11080 vldmr11080 mentioned this issue Jun 9, 2020
Merged
2 tasks
@enricogior enricogior mentioned this issue Jun 10, 2020
Closed
@enricogior enricogior added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Jun 11, 2020
@vldmr11080 vldmr11080 added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. labels Jun 11, 2020
@crutkas
Copy link
Member Author

crutkas commented Jun 30, 2020

Fixed in 0.19.0, please visit https://github.com/microsoft/PowerToys/releases/ for the latest release

@crutkas crutkas closed this as completed Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vldmr11080 vldmr11080

Labels
Area-Setup/Install Refers to installation mechanism Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Stability Release
Development

No branches or pull requests
5 participants
@crutkas @enricogior @codehz @vldmr11080 @htcfreek