Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Power toys-Image resizer]: Edit Buttons in Image Resizer Not Associated with Their Names and Dimensions. #36208

Closed
Anshi0420 opened this issue Dec 4, 2024 · 7 comments
Assignees
Labels
A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft A11ySev2 Accessibility team tag - P2 items A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Area-Accessibility Issues related to accessibility Issue-Bug Something isn't working Priority-2 Bug that is medium priority Product-Image Resizer Things regarding image resizing module Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete.

Comments

@Anshi0420
Copy link

Anshi0420 commented Dec 4, 2024

Microsoft PowerToys version

0.86.0

Installation method

PowerToys auto-update

Running as admin

None

Area(s) with issue?

Image Resizer

Steps to reproduce

Test environment:
OS Build: Windows 11 Enterprise Insider Preview 24H2 (26120.1340)
Power toys version: v0.86.0
Screen Reader: Narrator

Repro Steps:

  1. Open the Power Toys app in the desktop.
  2. Select the Image Resizer option from left navigation pane.
  3. Turn on narrator using Ctrl + Win + Enter.
  4. Now navigate to the Edit buttons present below the Add new buttons.
  5. Observe the issue.

User Experience:
Screen reader users will be unable to understand which button controls which dimension, making it difficult or impossible to resize images effectively.

Note:
Same issue is also repro for delete button.

Attachments:
Image

319933907-3c3a08d0-692b-4158-8c1e-576a4ca05d1d.mp4

Guideline reference:
https://www.w3.org/WAI/WCAG22/Understanding/info-and-relationships

✔️ Expected Behavior

Each edit button in the image resizer should have a descriptive label, either visually or programmatically, that clearly identifies its function and the dimensions it controls (e.g., "Set Width to 500px", "Set Height to 300px").

❌ Actual Behavior

The edit buttons in the image resizer tool are not properly labeled or associated with the corresponding image dimensions (e.g., width, height).

Other Software

No response

@Anshi0420 Anshi0420 added A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft A11ySev3 Accessibility team tag - P3 items A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Area-Accessibility Issues related to accessibility Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Product-Image Resizer Things regarding image resizing module labels Dec 4, 2024
Copy link

We've found some similar issues:

If any of the above are duplicates, please consider closing this issue out and adding additional context in the original issue.

Note: You can give me feedback by 👍 or 👎 this comment.

@Anshi0420 Anshi0420 added A11ySev2 Accessibility team tag - P2 items and removed A11ySev3 Accessibility team tag - P3 items labels Dec 4, 2024
@crutkas crutkas added the Priority-1 Bug that is high priority label Dec 9, 2024
@cinnamon-msft cinnamon-msft added Priority-2 Bug that is medium priority and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Priority-1 Bug that is high priority labels Jan 7, 2025
@htcfreek htcfreek added the Status-In progress This issue or work-item is under development label Jan 8, 2025
@htcfreek
Copy link
Collaborator

htcfreek commented Jan 8, 2025

@daverayment
Your contribution is welcome and thank you for your work on this. Feel free to open a PR. If you have any further questions don't worry to ask them.

@drawbyperpetual drawbyperpetual self-assigned this Jan 14, 2025
@drawbyperpetual
Copy link
Collaborator

@daverayment @htcfreek - Apologies for not noticing this earlier - I've worked on this and will raise a PR shortly. I hope there hasn't been any duplicated effort!

@daverayment
Copy link
Contributor

@drawbyperpetual I've just finished this myself, along with several other fixes, and was about to submit my own PR 😬

I'm not sure what's best here. My PR differs in a number of ways from yours, and covers several more issues I found, including problems with the ViewModel, ImageSize class etc.

I also used both AutomationProperties.Name and AutomationProperties.FullDescription for the accessibility text, rather than HelpText.

I will submit the PR then we can compare and contrast, maybe?

@daverayment
Copy link
Contributor

daverayment commented Jan 16, 2025

@drawbyperpetual @htcfreek I've submitted the PR. I've detailed everything (I hope!) in the notes.

@drawbyperpetual
Copy link
Collaborator

@daverayment I like all the nice refactorings in your PR; I'll cancel mine - let's get behind yours!

@daverayment
Copy link
Contributor

@daverayment I like all the nice refactorings in your PR; I'll cancel mine - let's get behind yours!

That's kind of you. Thank you very much.

@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Jan 21, 2025
@jaimecbernardo jaimecbernardo added this to the PowerToys 0.88 milestone Jan 21, 2025
@cinnamon-msft cinnamon-msft added Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete. and removed Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft A11ySev2 Accessibility team tag - P2 items A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Area-Accessibility Issues related to accessibility Issue-Bug Something isn't working Priority-2 Bug that is medium priority Product-Image Resizer Things regarding image resizing module Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete.
Projects
None yet
Development

No branches or pull requests

7 participants