-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Power toys-Image resizer]: Edit Buttons in Image Resizer Not Associated with Their Names and Dimensions. #36208
Comments
We've found some similar issues:
If any of the above are duplicates, please consider closing this issue out and adding additional context in the original issue.
|
@daverayment |
@daverayment @htcfreek - Apologies for not noticing this earlier - I've worked on this and will raise a PR shortly. I hope there hasn't been any duplicated effort! |
@drawbyperpetual I've just finished this myself, along with several other fixes, and was about to submit my own PR 😬 I'm not sure what's best here. My PR differs in a number of ways from yours, and covers several more issues I found, including problems with the ViewModel, ImageSize class etc. I also used both I will submit the PR then we can compare and contrast, maybe? |
@drawbyperpetual @htcfreek I've submitted the PR. I've detailed everything (I hope!) in the notes. |
@daverayment I like all the nice refactorings in your PR; I'll cancel mine - let's get behind yours! |
That's kind of you. Thank you very much. |
Microsoft PowerToys version
0.86.0
Installation method
PowerToys auto-update
Running as admin
None
Area(s) with issue?
Image Resizer
Steps to reproduce
Test environment:
OS Build: Windows 11 Enterprise Insider Preview 24H2 (26120.1340)
Power toys version: v0.86.0
Screen Reader: Narrator
Repro Steps:
User Experience:
Screen reader users will be unable to understand which button controls which dimension, making it difficult or impossible to resize images effectively.
Note:
Same issue is also repro for delete button.
Attachments:
319933907-3c3a08d0-692b-4158-8c1e-576a4ca05d1d.mp4
Guideline reference:
https://www.w3.org/WAI/WCAG22/Understanding/info-and-relationships
✔️ Expected Behavior
Each edit button in the image resizer should have a descriptive label, either visually or programmatically, that clearly identifies its function and the dimensions it controls (e.g., "Set Width to 500px", "Set Height to 300px").
❌ Actual Behavior
The edit buttons in the image resizer tool are not properly labeled or associated with the corresponding image dimensions (e.g., width, height).
Other Software
No response
The text was updated successfully, but these errors were encountered: