[Image Resizer] Accessibility - Made Edit / Remove buttons on Settings Screen associated with their presets #36900
+60
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htcfreek
reviewed
Jan 16, 2025
| @@ -49,6 +49,9 @@ public ImageSize(int id, string name, ResizeFit fit, double width, double height | |||
| private double _width; | |||
| private ResizeUnit _unit; | |||
|
|
|||
| [JsonIgnore] | |||
| public ImageSize Self { get => this; } // needed for data binding; change-notification raised when any property changes | |||
There was a problem hiding this comment.
add cmdconfigurignore too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Added the
AutomationProperties.HelpTextproperty to the Edit and Remove buttons so users can infer what presets they modify when using screen readers.PR Checklist
Detailed Description of the Pull Request / Additional comments
See linked issue.
Validation Steps Performed
Verified help text is read out sensibly for these buttons when using Narrator, including when settings are modified.