Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback Needed][PT Run] Applications in the PATH env variable for #4327

Closed
alekhyareddy28 opened this issue Jun 16, 2020 · 4 comments
Closed
Labels
Needs-Community Feedback We need additional help with how something should act / look Product-PowerToys Run Improved app launch PT Run (Win+R) Window

Comments

@alekhyareddy28
Copy link
Contributor

Summary of the new feature/enhancement

Related to issue #4200 - Find applications inside the path environment. There are multiple ways in which we can go about it. Following are the two different approaches and some example screenshots -

Approach 1

  • Show all the run command applications based on the same matching algorithm as used for the rest of the programs.
    eg1: cmd
    image

eg2: mmc
image

Approach 2

  • Show the run command application only when there is a complete match to avoid clutter.
    eg1: cmd
    image

eg2: mmc
image

@alekhyareddy28 alekhyareddy28 added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Jun 16, 2020
@alekhyareddy28 alekhyareddy28 changed the title [Community Feedback Requested] Applications in the PATH env variable [PowerToys Run][Community Feedback Requested] Applications in the PATH env variable Jun 16, 2020
@crutkas crutkas added the Needs-Community Feedback We need additional help with how something should act / look label Jun 16, 2020
@crutkas crutkas pinned this issue Jun 16, 2020
@crutkas crutkas changed the title [PowerToys Run][Community Feedback Requested] Applications in the PATH env variable [Feedback Needed][PT Run] Applications in the PATH env variable for Jun 16, 2020
@htcfreek
Copy link
Collaborator

htcfreek commented Jun 16, 2020

Why do we classify the results as "Run Command Application"?

I think we should take car not showing "cmd" and "Command Prompt" or "mmc" and "Management Console". The we should show it as "Command Prompt" and "Management Console".

Not shure if it's better to only show on exact match.

@alekhyareddy28
Can you please test, if you can open gpedit.msc as "Run command application". It's issue #3434. Thank you.

@htcfreek
Copy link
Collaborator

htcfreek commented Jun 16, 2020

Not shure if it's better to only show on exact match.

I had first misunderstanding the question.

My opinion:
We should have an exact sub match behaviour. So when I search for mmc the strings mm & mmc & mmc.exe should match for it. But mmc should not bring results like MediaMgrCtl.exe for example.

@auchri
Copy link

auchri commented Jun 17, 2020

But mmc should not bring results like MediaMgrCtl.exe for example.

Well, imho this would be a very useful feature which is also implemented in e.g. IntelliJ to find classes or variables.

For example if you want to find the ThisIsMyLongName.exe instead of typing the whole name you can just type TIMLN

@crutkas
Copy link
Member

crutkas commented Jul 30, 2020

we're opt'ing for how we're currently executing the code path which mimics start menu

@crutkas crutkas closed this as completed Jul 30, 2020
@crutkas crutkas unpinned this issue Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Community Feedback We need additional help with how something should act / look Product-PowerToys Run Improved app launch PT Run (Win+R) Window
Projects
None yet
Development

No branches or pull requests

4 participants