Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose our own UI language #7670

Closed
iamshilov opened this issue Oct 30, 2020 · 140 comments
Closed

Choose our own UI language #7670

iamshilov opened this issue Oct 30, 2020 · 140 comments
Assignees
Labels
Area-Localization issues regarding to Localization the application Cost-Large Large work item - 3+ days worth of work (chances are needs to be broken down) Idea-Enhancement New feature or request on an existing product Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@iamshilov
Copy link

Thanks for localization, but can we have a choice?

@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Oct 30, 2020
@htcfreek
Copy link
Collaborator

htcfreek commented Oct 30, 2020

You suggest what I think since a few weeks. 😂

@htcfreek htcfreek added Area-Localization issues regarding to Localization the application Product-Settings The standalone PowerToys Settings application labels Oct 30, 2020
@Aaron-Junker Aaron-Junker added Idea-Enhancement New feature or request on an existing product and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 30, 2020
@crutkas
Copy link
Member

crutkas commented Oct 30, 2020

This is based on your OS. We could have an override setting.

@arjunbalgovind
Copy link
Contributor

@crutkas This would most likely be a big work item, since right now we are relying on the default behavior for all 3 platforms (.NET, C++ and UWP). We would need to add custom logic for loading the resources in all the projects (unless there are some convenient APIs for all the platforms to switch languages).

@crutkas
Copy link
Member

crutkas commented Oct 31, 2020

for .net / winrt, there should be. The C++ stuff ... that could be more interesting. Great call out

@NenoLoje
Copy link

If we were to change the thread's culture early in the start-up phase, wouldn't that solve the issue?

@htcfreek
Copy link
Collaborator

If we were to change the thread's culture early in the start-up phase, wouldn't that solve the issue?

You mean with restart for lang change?

@NenoLoje
Copy link

You mean with restart for lang change?

Yes, that's right.

@carlosmatioli
Copy link

This "Choose Language" feature would help me in the issue presented in the picture attached. The translated sentence in pt-BR is beyond window limits, and I cannot change the properties.

image

@enricogior
Copy link
Contributor

@carlosmatioli
this issue is not about UI fixes for bugs caused by translation.
The problem you reported has already been fixed an it will be available in the next release
#7689

I will delete your comment and mine to keep this thread on topic.
Thank.

@Jay-o-Way
Copy link
Collaborator

This is really a good idea. Not only for personal use, but also handy when I want to make a screenshot to show on GitHub. My app is Dutch now and it would be better for other people when I can show something in English, or any language that fits.
Plenty of apps can do this on the spot, so no restart of any kind should be necessary.

@crutkas
Copy link
Member

crutkas commented Nov 20, 2020

I think it is a good idea, just hard. Why: the front end techs are not unified. We use MFC, WPF, Winforms, UWP/WinUI, and i think one more.

Each UI framework would have to have a different solution == extremely time consuming until we unify

@crutkas crutkas added this to the Suggested Enhancements milestone Nov 20, 2020
@crutkas
Copy link
Member

crutkas commented Nov 21, 2020

Will be much easier once everything is in the same stack.

@erdostamasa
Copy link

So are there plans to solve this in the future?

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Jan 24, 2021

We use MFC, WPF, Winforms, UWP/WinUI, and i think one more.

I still can't wrap my head around this. It's very confusing and (I suppose) can't be very efficient. In my head GIT always has been the abbreviation for Get It Together. Something Microsoft can't seem to grasp.

@crutkas
Copy link
Member

crutkas commented Jan 24, 2021

@erdostamasa I can see doing the work but I don’t a clear reason for why they would want this to not be their OS choice. This is future work as well and requires other work items to be done first.

@Jay-o-Way we inherited tech techs from other OSS projects. If they use let’s say MFC, for us to migrate is a big undertaking. We know where we want to go (WinUI) but it is missing unpackaged support. So at this time it means we can’t migrate. Upgrading from UI stacks also can introduce a host of bugs so doing it multiple times doesn’t make much sense when we know in the short term, we’ll get to where we need to be.

Rather spend the dev cycles in other parts of code.

we are a small team with great community support. Things take time.

@Jay-o-Way

This comment has been minimized.

@crutkas
Copy link
Member

crutkas commented Jan 25, 2021

Jay, powertoys respects the OS language setting. This ask is to override that

@NenoLoje
Copy link

Jay, powertoys respects the OS language setting. This ask is to override that

@crutkas Hey Clint - what if we were to create a separate .exe file that would contain only the default (English) UI? Then customers could choose this one, or the current one (which defaults to the OS language setting)

@ALL - would that be sufficient?

@Jay-o-Way
Copy link
Collaborator

@NenoLoje Sorry, but that is not the way to achieve this.

@crutkas
Copy link
Member

crutkas commented Jan 25, 2021

@NenoLoje we would not do that style solution, forcing language can be done but it is per UI framework and has other ramifications.

TLDR: Dragons be here so we need to be sure we're doing this correctly. Lots of testing and edge cases.

@Mario-Hofstaetter
Copy link

@aron

as this issue is currently on our roadmap and will be fixed in the near future.

Great to hear, I can only see it being pushed from release to release. And this issue being open for a long time.

It just feels strange, that a show-stopper issue for the majority of the users is just pushed for such a long time. It feels like the core team doesn’t understand that the translated versions are nearly unusable. It’s really bad. And it could even be easily fixed by just removing the translations completely.

Since I found this issue (which is just sad), I just tried to remove the translations by force (in my case German, I just want English texts...) and nuke all German language files.

  • I deleted all folders named "de-DE", Powertoys launched but Settings where still German
  • However it DID SUCCESSFULLY set Run / Powerlauncher to english for me. But not e.g. PowerRename (which has a PowerToys.PowerRename.pri), I have not tested all the other tools
  • Then used file content search for a String, found PowerToys.Settings.pri , but after deleting it the Settings Dialog will no longer open (No Error Message)

I am not familiar with how .pri files work for language resources.
Is there any way to remove just one language from the file? If the OS language is not found, I assume it falls back do eng?
I would be ok with doing that again after each update until this is fixed in the future.

It is 2024 and more and more programs won't let you choose the language, especially Android Apps, but this is offtopic..

@andi0b
Copy link

andi0b commented Sep 6, 2024

@Aaron-Junker Is there an estimate when we can expect a de-localized version of powertoys? Otherwise it's maybe really time to set up a community build that just strips all the translations. It's such a shame this great tool is practically unusable for 95% of the users in the world, because of the broken translations.

@stefansjfw
Copy link
Collaborator

stefansjfw commented Sep 6, 2024

WindowsAppSDK 1.6 introduced what was needed for this. It was release few days ago. We will upgrade to it soon and then work on adding a setting to select a specific language

@kngfbng
Copy link

kngfbng commented Sep 11, 2024

@stefansjfw Pardon my skepticism, but a language setting in Powertoys to me is like fusion powerplants and flying cars: It's always just around the corner, coming anytime now! 😂

I'll believe it when I see it and I can't wait to be converted.

@stefansjfw
Copy link
Collaborator

@stefansjfw Pardon my skepticism, but a language setting in Powertoys to me is like fusion powerplants and flying cars: It's always just around the corner, coming anytime now! 😂

I'll believe it when I see it and I can't wait to be converted.

Say no more. #34971
Needs a bit of polishing, but should land soon

@crutkas
Copy link
Member

crutkas commented Sep 19, 2024

@stefansjfw Pardon my skepticism, but a language setting in Powertoys to me is like fusion powerplants and flying cars: It's always just around the corner, coming anytime now! 😂

I'll believe it when I see it and I can't wait to be converted.

For this to be successful, i made the call of "all of it" must work. We host pretty much every major UX framework and have a pretty seamless experience. As an end user, you need to know what something is made with, just it feels like the other tools.

TLDR: Stuff is complicated, the building bricks need to present, if not, gotta build them :)

@crutkas crutkas added the Status-In progress This issue or work-item is under development label Sep 21, 2024
@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Sep 25, 2024
@crutkas
Copy link
Member

crutkas commented Oct 4, 2024

Done in 0.85! My OS is set to English, PowerToys was set to German, you can see PT Run and Settings in German!

image

@Korb
Copy link

Korb commented Oct 5, 2024

Done in 0.85!

I confirm that in Microsoft Windows 10.0.19045.4957 the behavior of the "Application language" setting is as expected.

@jaimecbernardo
Copy link
Collaborator

This issue has been worked on during the 0.85 development cycle. Please update to the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Localization issues regarding to Localization the application Cost-Large Large work item - 3+ days worth of work (chances are needs to be broken down) Idea-Enhancement New feature or request on an existing product Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
Archived in project
Status: Done
Development

No branches or pull requests