Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] Unreachable input box in FancyZones Editor fix. #7689

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

SeraphimaZykova
Copy link
Collaborator

Summary of the Pull Request

Changed text position in the main editor window. Wrap text in case if it won't fit into the line width.

PR Checklist

Info on Pull Request

Снимок1 (3)

Снимок (2)

Снимок3 (2)

Validation Steps Performed

For testing, you can set desired values for Space_Around_Zones or Distance_adjacent_zones in the resource file.

@enricogior
Copy link
Contributor

I think it would be better to have Show spaces around zones and Space around zone on the same row and put `Distance to highlight adjacent zones" in its own row.

@SeraphimaZykova
Copy link
Collaborator Author

I think it would be better to have Show spaces around zones and Space around zone on the same row and put `Distance to highlight adjacent zones" in its own row.

Should it better be on the left or on the right?

1
2

@enricogior
Copy link
Contributor

@SeraphimaZ
the second one, the one on the left.

@SeraphimaZykova
Copy link
Collaborator Author

@SeraphimaZ
the second one, the one on the left.

Done.

@enricogior enricogior added Area-Localization issues regarding to Localization the application FancyZones-Editor Issue revolving the FancyZone Editor labels Oct 30, 2020
@SeraphimaZykova SeraphimaZykova merged commit 4a7ce82 into microsoft:master Oct 30, 2020
@SeraphimaZykova SeraphimaZykova deleted the issue_7634 branch October 30, 2020 16:00
@Jay-o-Way
Copy link
Collaborator

I know this is too late, but why not combine the check box and the input control into one? And also add the unit "px".

  • Show space around zones: [_____] px

@enricogior
Copy link
Contributor

@Jay-o-Way
good idea, but since we are going to change the UI significantly, we are not going to make individual fixes for the current one.

@jsoref
Copy link
Contributor

jsoref commented Nov 8, 2020

Be careful about doing something like that. Some languages put units before, some after. Localizing such things can be really challenging.

English / US / Dollars
English / Europe / Special Drawing Rights

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Nov 8, 2020

@jsoref You are right. But I think it can be done with the right words, for example "Number of px around zones: [___]"
Just wanted to point out the redundancy when you see the text "show space around zones" and "space around zones" next to each other.

@jsoref
Copy link
Contributor

jsoref commented Nov 8, 2020

I'd probably do:

/- [x] Pad zones -\
|   Padding [   ] |
\-----------------/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Localization issues regarding to Localization the application FancyZones-Editor Issue revolving the FancyZone Editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants