Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCOOBE Spec #13138

Merged
merged 4 commits into from
Oct 7, 2021
Merged

SCOOBE Spec #13138

merged 4 commits into from
Oct 7, 2021

Conversation

dedavis6797
Copy link
Contributor

Summary of the Pull Request

Redoing #10978. For whatever reason I couldn't resolve the lingering error, so I'm just rebasing the PR off the current master branch.

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To better understand the spec, it'd be helpful to have the mentioned pictures available. Could these be added, please?

@crutkas
Copy link
Member

crutkas commented Oct 6, 2021

@dedavis6797 what is needed to wrap this spec up?

@dedavis6797
Copy link
Contributor Author

The spec has been updated, @jaimecbernardo let me know if additional clarity is needed here.

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dedavis6797 dedavis6797 merged commit 2c58475 into master Oct 7, 2021
@dedavis6797 dedavis6797 deleted the specs/SCOOBE_Spec branch October 7, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants