Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FancyZones]Fallback and fixes for GetDisplays #19380

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

Fixes issues with FancyZones Editor not opening after the monitor identification work.

PR Checklist

Detailed Description of the Pull Request / Additional comments

With the new monitor identification code, FancyZones was failing in cases where EnumDisplayDevicesW didn't detect any monitors connected to a display device.
It also looks for the active monitor inside each display device since it's possible for a monitor to be inactive and the correct one for the display will be another monitor connected to the display device.

Validation Steps Performed

Asked the users from the issues to test it on their configurations, since I've got no physical or virtual machine capable of replicating the same conditions for the users.

Copy link
Collaborator

@stefansjfw stefansjfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on my setup, couldn't reproduce the issue neither before or now. Change looks good.

Copy link

@Chameleon-Coder Chameleon-Coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. This was merged. My bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants