[MWB]Work without service if service doesn't start #26521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaimecbernardo
added
the
Hot Fix
yuyoyuppe
approved these changes
May 31, 2023
BLM16
pushed a commit
to BLM16/PowerToys
that referenced
this pull request
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Currently, Mouse Without Borders won't work correctly if the service is deleted but the user has the Use Service option turned on.
This PR adds some code to make MouseWithoutBorders start without the service and disable the Setting if it can't start the service.
It also disables the Use Service option if that's the case.
Validation Steps Performed
Set PowerToys Mouse Without Borders to use the service.
Exit PowerToys.
delete the service.
Start PowerToys without admin permissions.
Mouse Without Borders will still start correctly and disable the service mode.