Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings]Fix links to the Text Extractor page #32355

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

On 0.80.0, links from Text extractor util to its Settings page or from PowerToys plugin of PT Run were broken.
This seems to have been caused by the change from "PowerOCR" to "PowerOcr" to help in the DSC PR.
This PR converts the other strings that stayed as "PowerOCR" to "PowerOcr".

PR Checklist

Validation Steps Performed

From Text Extractor util, press the settings button and verify it opens Settings in the Text Extractor page.
From PT Run PowerToys plugin, search for Text Extractor and press the Settings button.
From Dashboard, press the Text Extractor entry and verify it opens the Text Extractor Settings page.
From OOBE, press the button that opens the Text Extractor settings page.

Copy link
Collaborator

@davidegiacometti davidegiacometti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Tested in Text Extractor, Dashboard, OOBE, Run and it's working as expected.

@Jay-o-Way Jay-o-Way removed their request for review April 9, 2024 17:11
@Jay-o-Way
Copy link
Collaborator

A basic search for "PowerOCR" (case sensitive) returns a lot of results. For one example in launcher ... UtilityHelper.cs --> SettingsDeepLink.SettingsWindow? GetSettingsWindow(UtilityKey key)
Apparently, this does work nicely - and therefore not needed here. Would it make sense to align this syntax, though?

@jaimecbernardo
Copy link
Collaborator Author

A basic search for "PowerOCR" (case sensitive) returns a lot of results. For one example in launcher ... UtilityHelper.cs --> SettingsDeepLink.SettingsWindow? GetSettingsWindow(UtilityKey key) Apparently, this does work nicely - and therefore not needed here. Would it make sense to align this syntax, though?

One is the strings passed around and the other is the Enum identifier. Perhaps aligning would be good, but for a hotfix I prefer as little change as possible to reduce the surface that might have errors.

@jaimecbernardo jaimecbernardo merged commit 9ecdbb0 into main Apr 9, 2024
15 checks passed
@crutkas crutkas deleted the dev/jaime/fix-settings-power-ocr-links branch May 20, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants