-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FancyZones] App zone history on multiple desktops #3932
[FancyZones] App zone history on multiple desktops #3932
Conversation
@vldmr11080 |
No, last few of them were just minor changes in unit tests, and they are finished now. Core |
Is it expected that in Repro steps:
App will be removed from all layouts. |
Thanks for the catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! App history is saved for different VDs properly.
I played with it and tried besides described behavior removing VD while PT is not running and for me all scenarios works well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both validation scenarios work. I also checked that settings from v0.18.1 are migrated correctly. Unit tests work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested, both scenarios works.
edaa7e0
to
2c25a3f
Compare
This fixes the virtual desktop issue, we still have to fix history for multi monitor. |
Summary of the Pull Request
PR Checklist
Validation Steps Performed
Multiple desktops app zone history:
C:\Users\<user>\AppData\Local\Microsoft\PowerToys\FancyZones
filesapp-zone-history.json
.Expected result: Information about zone history of single application contains information for different desktops, after application is opened, it goes to the different zone based on which desktop it is.
App zone history data of deleted desktop:
C:\Users\<user>\AppData\Local\Microsoft\PowerToys\FancyZones
filesapp-zone-history.json
andzones-settings.json
.Expected result: No data belonging to deleted desktops is found.