[PT Run] Added dummy key event to prevent Start Menu from popping up #4874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunbalgovind
added
the
Product-PowerToys Run
enricogior
reviewed
Jul 8, 2020
enricogior
approved these changes
Jul 8, 2020
alekhyareddy28
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR tweaks the HotkeyManager code such that a dummy key event is sent after invoking the shortcut. This is required to prevent Start Menu from popping up in the scenario where user releases Win key before Space (if Win+Space is the shortcut). The same procedure is done in Keyboard Manager when remapping shortcuts, because in case of Windows shortcuts Start menu appears, and if its an Alt based shortcut, the application's menu bar may get triggered.
PR Checklist
Validation Steps Performed
Validated manually that Start menu doesn't open while releasing Win key before Space.