Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial project plan #1

Merged
merged 1 commit into from
Jun 10, 2015
Merged

initial project plan #1

merged 1 commit into from
Jun 10, 2015

Conversation

alexcjohnson
Copy link
Contributor

@qdev-dk/qcodes this is a long time coming as I'm still disentangling myself from my other job 😄 - but here's the general outline that we came up with at the meeting a few weeks ago. Comments, additions, corrections are all welcome!

@guenp I haven't figured out the correspondence between all the real people and their github ids - anyone else we still need?

@alexcjohnson
Copy link
Contributor Author

If you're not familiar with github's pull requests, the easiest way to look at this doc is to click on "Files changed," then "Display the rich diff" to see the markdown rendered, but then go back to "Display the source diff" and click on the plus sign next to a line number in order to comment on a particular line.

screen shot 2015-06-09 at 5 38 58 pm 2

chrede88 pushed a commit that referenced this pull request Jun 10, 2015
@chrede88 chrede88 merged commit 74bcf86 into master Jun 10, 2015
@alexcjohnson
Copy link
Contributor Author

@chrede88 I take it merging means you agree with all this? Comments from all are still welcome here.

In the future, assuming the pull request is made by a core contributor who's authorized to merge (which is mostly going to be me I imagine) let's follow this protocol:

  • Let the requestor merge when they've gotten sufficient approval
  • For bigger changes, don't merge until everyone has had a chance to take a look (~ one workday - anyone who doesn't bother commenting in that time is assumed to have no input to give.)
  • For smaller changes (esp. bugfixes) one approval is sufficient
  • At Plotly we've been using 💃 which is written :dancer: to mean "approved - OK to merge" - lets keep that. It's more fun than 🚢 or github's :shipit: "shipit squirrel."

Even if it's generally just me writing most of this, I'll still try to get someone else to peek at each new piece of code - I'll try to spread it around so nobody is overloaded but everyone stays in the loop.

@chrede88
Copy link

Hehe.. Sure:) wasn't sure how we were supposed to act!

Sent from my iPhone

On Jun 10, 2015, at 20:52, alexcjohnson [email protected] wrote:

@chrede88 I take it merging means you agree with all this? Comments from all are still welcome here.

In the future, assuming the pull request is made by a core contributor who's authorized to merge (which is mostly going to be me I imagine) let's follow this protocol:

Let the requestor merge when they've gotten sufficient approval
For bigger changes, don't merge until everyone has had a chance to take a look (~ one workday - anyone who doesn't bother commenting in that time is assumed to have no input to give.)
For smaller changes (esp. bugfixes) one approval is sufficient
At Plotly we've been using which is written 💃 to mean "approved - OK to merge" - lets keep that. It's more fun than or github's "shipit squirrel."
Even if it's generally just me writing most of this, I'll still try to get someone else to peek at each new piece of code - I'll try to spread it around so nobody is overloaded but everyone stays in the loop.


Reply to this email directly or view it on GitHub.

@guenp
Copy link
Contributor

guenp commented Jun 12, 2015

@alexcjohnson looking good - I say let's dance! 💃 @majacassidy @spauka is there anyone from your teams who still needs to be added to the github team?
btw - I've just signed onto a fridge and now started using jupyter/python 3 to take data. it's not that advanced (no high-level sweep functions etc), but am using the instrument framework from michael's code + pandas hdfstore + matplotlib. I'll create a repo in the organization with the code once I have time.
image

@MerlinSmiles
Copy link
Contributor

A phone app to check the current measurement/fridge status would make me double 👯 during phase 3

@AdriaanRol
Copy link
Contributor

Hi Guen,

Looks good :)

Could you also add Christian Dickel to the QCodes group? His Github id is
cdickel.

Cheers,

Adriaan

On Fri, Jun 12, 2015 at 10:04 PM Guen P [email protected] wrote:

@alexcjohnson https://github.com/alexcjohnson looking good - I say
let's dance! [image: 💃] @majacassidy
https://github.com/majacassidy @spauka https://github.com/spauka is
there anyone from your teams who still needs to be added to the github team?
btw - I've just signed onto a fridge and now started using jupyter/python
3 to take data. it's not that advanced (no high-level sweep functions etc),
but am using the instrument framework from michael's code + pandas hdfstore


Reply to this email directly or view it on GitHub
qdev-dk-archive#1 (comment).

@spauka
Copy link
Contributor

spauka commented Jun 13, 2015

Hey,

Everything looks great! Is there still a plan to present something at the meeting in a few weeks? Will there be anything extra to prepare before then?

I'll let you know if there is anyone to add shortly...

Sebastian

@dbwz8
Copy link

dbwz8 commented Jun 13, 2015

There won’t be anything formal at the meeting (too early). Alan and I will be meeting with the PIs to get buy-in and agreement on strategy for development and release. We’ll keep everyone informed as to results.

From: Sebastian Pauka [mailto:[email protected]]
Sent: Saturday, June 13, 2015 7:39 AM
To: qdev-dk/Qcodes
Cc: Dave Wecker
Subject: Re: [Qcodes] initial project plan (#1)

Hey,

Everything looks great! Is there still a plan to present something at the meeting in a few weeks? Will there be anything extra to prepare before then?

I'll let you know if there is anyone to add shortly...

Sebastian


Reply to this email directly or view it on GitHub qdev-dk-archive#1 (comment) . https://github.com/notifications/beacon/AKEAqV6y1Ho_y7gC5D0W5429S563_XEqks5oTDgcgaJpZM4E9rcP.gif

@majacassidy
Copy link

Hi All,

Can you please add my student Damaz de Jong (github ID: Damazter) to the group. He is doing a lot of the advanced code development from our side.

For an 'app' for checking on measurements/fridges, we use freeboard together with dweet. It will take you less than 30 mins to get set up and be dweeting the status of your fridges/measurements that you can view in a browser.

As an example, our fridge monitoring board is here:
https://freeboard.io/board/53e88340674294f02a0000e1

More info on dweet is at dweet.io.

There is a python package 'dweepy' that allows you to send your messages.

The latest version of the code for handling dweets for an Oxford fridge is available on Damaz's github account.

Best,

Maja

@MerlinSmiles
Copy link
Contributor

@majacassidy that looks pretty cool 💃 thanks!

@alexcjohnson
Copy link
Contributor Author

@AdriaanRol : @cdickel has been invited but hasn't accepted yet.

@majacassidy : I've invited @damazter - thanks! And dweet / freeboard does look pretty cool.

@guenp
Copy link
Contributor

guenp commented Jun 22, 2015

fyi, I've forked the code I've been using to take data here:
https://github.com/qdev-dk/athena
it's based on part of the code that Michael wrote + pandas + matplotlib. it runs on python 3 and I'm using it in ipython notebook. it's very crude (no high level sweep functions or auto-logging of variables) but it works for my purposes (I dislike matlab & igor, and qtlab was too much hassle for me to install).

@alexcjohnson I'd like to implement threading or multiprocessing to speed up my data acq. I tried using the instrument server (based on rpyc) but it's giving me virtual memory issues.. so now I just load the instrument channels in the same process as the experiment, but would like to do that separately so I can talk to the same set of instrument channels from multiple notebooks. do you have any advice on how to make the instrument channels live in their own process? would you use threading or a socket or..? (same goes for a 'plotting' and 'data storage' process)

Also, I happened to pass by the lab in Delft last week and here's some results/ideas from talking to @damazter and @AdriaanRol

  • instrument drivers need to be modular ('import Alazar') and some could have their own github repo
  • it should be easy to log instrument settings (as metadata) without limiting them to a 'get/set parameter' framework (as in qtlab)
  • @AdriaanRol is working on a new version of their experiment control object (C2Q6), it's an advanced 'instrument' that can do sub-experiments (e.g. 'get resonance freq') and saves the results as attributes
  • if qcodes is to be used in the LdC lab, it should be done in phases. LK lab can be converted more easily. LdC lab could mostly benefit from a fast live plotting library
  • @damazter shared his fridgecontrol code (with dweepy/freeboard), I will implement & test this on our fridge
  • measurements scripts can be saved on github (use commit id in experimental metadata)

@dbwz8
Copy link

dbwz8 commented Jun 23, 2015

@guenp just so you know, Alex is on vacation (driving down the left coast of the U.S.) and will then be moving until mid-July, so don't expect a speedy response. I saw him here last week in Seattle but he's now pretty much incommunicado.

@alexcjohnson
Copy link
Contributor Author

@guenp thanks for the input!

I don't have any a priori conclusion about the best way to separate the processes. I've never used rpyc but it may be worthwhile to pursue that a little as it should be more flexible than the other solutions I'm aware of - we may just need to be careful to keep its connections lightweight - though that would sacrifice some of the flexibility 😾 in which case we might be better off going back to straight sockets or via a message queue (might be the most robust solution, but not the lightest, and then we have to worry about extra installation dependencies)

@alexcjohnson alexcjohnson deleted the project-plan branch February 22, 2016 14:22
@AdriaanRol AdriaanRol mentioned this pull request Feb 16, 2017
jenshnielsen added a commit that referenced this pull request Nov 6, 2017
* beginnings of vna driver extension to get spectroscopy mode working

* debug spec mode on ZNB

* measuting with ZNB

* removed T3 specific modifications, now in wrappers pr #1

* removed unused imports, time and partial

* The znb may return a float so round before casting to an int
Dominik-Vogel referenced this pull request in Dominik-Vogel/Qcodes Dec 8, 2017
Dominik-Vogel pushed a commit that referenced this pull request May 22, 2018
sohailc pushed a commit that referenced this pull request Jul 10, 2018
sync from QCodes master
@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@23f2fe2). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master      #1   +/-   ##
========================================
  Coverage          ?   79.9%           
========================================
  Files             ?      49           
  Lines             ?    6673           
  Branches          ?       0           
========================================
  Hits              ?    5332           
  Misses            ?    1341           
  Partials          ?       0

WilliamHPNielsen pushed a commit that referenced this pull request Dec 18, 2018
* [DEM-564] Create a new HDAWG8 driver from ZI example
astafan8 pushed a commit that referenced this pull request Mar 1, 2019
Typofix: changed 'NOR' to 'NORM', so it works
astafan8 pushed a commit that referenced this pull request Apr 9, 2019
astafan8 pushed a commit that referenced this pull request Dec 18, 2019
sync my fork to upstream master
astafan8 pushed a commit that referenced this pull request Jan 13, 2020
Pull master from core QCoDeS
astafan8 pushed a commit that referenced this pull request Jan 13, 2020
Dominik-Vogel pushed a commit that referenced this pull request Mar 2, 2020
WilliamHPNielsen pushed a commit that referenced this pull request Mar 16, 2020
Integrate Change from estebans pr
astafan8 pushed a commit that referenced this pull request Aug 4, 2020
github-actions bot pushed a commit that referenced this pull request Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants