-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Znb read from existing channels #1111
Znb read from existing channels #1111
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1111 +/- ##
=======================================
Coverage 70.66% 70.66%
=======================================
Files 102 102
Lines 11585 11585
=======================================
Hits 8186 8186
Misses 3399 3399 |
It may be needed for the user to call it
operation does not work correctly
So I would much prefer to have this done in a proper way but I think this is good enough to be useful. And I have a hart time seeing how we would get enough bandwidth to implement all the functionality needed to setup more advanced channels on the ZNB without relying on using the front panel. @QCoDeS/core What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the incremental approach here due to the complexity of the instrument.
Big thanks for reworking the notebook!!! Minor comments on the notebook:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that looks very sensible. If you feel in the mood for it you could add an example for the trace_mag_phase
parameter.
@Dominik-Vogel There is an example of that in [17] as far as I can see |
Merge: fa0b8d2 57d0cf6 Author: Jens Hedegaard Nielsen <[email protected]> Merge pull request #1111 from jenshnielsen/znb_existing_channels
@QCoDeS/core This enables reading channels that are already mapped on the ZNB from a manual user config. This is sort of a stop gap solution because we cant fully setup everything with the driver yet.
For use by @GrigoryanRuben