Add set_parameter_bounds to IVVI.py #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1128 +/- ##
=======================================
Coverage 79.97% 79.97%
=======================================
Files 49 49
Lines 6678 6678
=======================================
Hits 5341 5341
Misses 1337 1337 |
| # self.set_parameter_bounds('dac%d' % (i+1), val, val + | ||
| # self.Fullrange.0) | ||
| self.set_parameter_bounds('dac%d' % (i+1), val, val + | ||
| self.Fullrange.0) |
There was a problem hiding this comment.
I don't think this line split is valid python code
| @@ -459,6 +460,13 @@ def get_pol_dac(self, channel): | |||
| return 'POS' | |||
| else: | |||
| return 'Invalid polarity in memory' | |||
|
|
|||
| def set_parameter_bounds(name, min_value, max_value): | |||
There was a problem hiding this comment.
This is missing a self argument. Look at the function just below for an example
|
@kNalj Can you remove the whitespaces that Codacy noticed then I think this should be ready |
|
BUMP |
giulioungaretti
pushed a commit
that referenced
this pull request
Jul 27, 2018
Merge: 3d49344 53f97c0 Author: Mikhail Astafev <[email protected]> Merge pull request #1128 from kNalj/patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
@WilliamHPNielsen