Fix validation of steps #1176
Merged
Fix validation of steps #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This failed because the number of validation calls generated have changed. Intermediate steps are validated after setting with the following logic. self._save_val(val_step,
validate=(self.val_mapping is None and
self.set_parser is None and
not(step_index == len(steps)-1 or
len(steps) == 1)))I am not sure I see the need for that if we validate them up front too. Perhaps we should get rid of it. Validating before setting seems like the correct thing to do in any case |
Codecov Report
@@ Coverage Diff @@
## master #1176 +/- ##
==========================================
- Coverage 79.67% 79.66% -0.02%
==========================================
Files 47 47
Lines 6661 6662 +1
==========================================
Hits 5307 5307
- Misses 1354 1355 +1 |
astafan8
approved these changes
Jul 5, 2018
giulioungaretti
pushed a commit
that referenced
this pull request
Jul 6, 2018
Merge: 0d85481 f7469d1 Author: Jens Hedegaard Nielsen <[email protected]> Merge pull request #1176 from jenshnielsen/fix_validation_of_steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1174
Ensure that intermediate steps are validated too. In general we cannot assume that a step is valid just because the endpoint is