GroupParameter and Group (for visa commands that set/get more than one parameter at once) #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1232 +/- ##
==========================================
+ Coverage 80.77% 80.85% +0.08%
==========================================
Files 49 50 +1
Lines 6841 6886 +45
==========================================
+ Hits 5526 5568 +42
- Misses 1315 1318 +3 |
…event "shaddowing" of the attributes in the base class.
…odes into feature/GroupParameter
… same signature as the base class
astafan8
reviewed
Aug 17, 2018
qcodes/instrument/group_parameter.py
Outdated
| def __init__(self, name: str, instrument: Instrument, **kwargs) -> None: | ||
| self.group: Union[Group, None] = None | ||
| super().__init__(name, instrument=instrument, **kwargs) | ||
|
|
||
| def set_raw(self, value: Any): | ||
| self.group.set(self, value) | ||
| self.set_raw = lambda value: self.group.set(self, value) |
There was a problem hiding this comment.
as we've discussed, i'm ok with reducing the code quality for the sake of keeping this code more readable. It's just the design of Parameter and _BaseParameter does not allow a clean way of redefining set_raw/get_raw. Once the design is fixed, the original implementation of GroupParameter will be correct (and most readable). Hence, I recommend to revert this commit. @jenshnielsen @WilliamHPNielsen
sohailc
requested review from
WilliamHPNielsen
and removed request for
Dominik-Vogel
giulioungaretti
pushed a commit
that referenced
this pull request
Aug 17, 2018
Merge: 1470658 b43ae7a Author: sohail chatoor <[email protected]> Merge pull request #1232 from QCoDeS/feature/GroupParameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a separate PR for the GroupParameter and added a basic test