Add Alazar ATS9373 driver #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only adjustments to the original 9360 driver so far are: - change minimal firmware version for trigger hold-off feature - find&replace the board model name across the driver
astafan8
requested review from
jenshnielsen,
WilliamHPNielsen and
Dominik-Vogel
Codecov Report
@@ Coverage Diff @@
## master #1324 +/- ##
=======================================
Coverage 72.57% 72.57%
=======================================
Files 74 74
Lines 8473 8473
=======================================
Hits 6149 6149
Misses 2324 2324 |
jenshnielsen
approved these changes
Oct 18, 2018
giulioungaretti
pushed a commit
that referenced
this pull request
Oct 18, 2018
Merge: da65135 1c75f52 Author: Mikhail Astafev <[email protected]> Merge pull request #1324 from astafan8/driver/ats9373
astafan8
added a commit
to kouwenhovenlab/pytopo
that referenced
this pull request
Feb 13, 2019
A bit more mature version has been added to qcodes 3 months ago. See microsoft/Qcodes#1324.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver for
ATS9373board is basically a copy ofATS9360. The only differences are in available values for two parameters (see commits for more info) and the minimal firmware version for the trigger holdoff feature.Yes, this driver introduces tons of code duplication. But I'd rather have this problem sorted out in a separate PR. There are many refactorings that can be done to the
AlazarTechmodule.Contents of this PR:
AlazarTech ATS9373driver, as rip-off from9360with some minor modifications for some parameters