-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor / experiment init #1332
Refactor / experiment init #1332
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1332 +/- ##
==========================================
+ Coverage 72.55% 72.57% +0.02%
==========================================
Files 74 74
Lines 8569 8577 +8
==========================================
+ Hits 6217 6225 +8
Misses 2352 2352 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work! just some minor things to do in my opinion, see comments
|
||
def _new(self, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, there was no problem with the _new
method. It has _
, hence noone should call from outside of the class. But that was exactly the problem :) anyway, of you feel like, please don't hesitate to encapsulate the else
-clause part of the logic into a private method in order to increase readability of the __init__
method.
Merge: a6d4c22 bc54dde Author: William H.P. Nielsen <[email protected]> Merge pull request #1332 from WilliamHPNielsen/refactor/experiment_init
In the spirit of #1323, this PR proposed to do the same for the
Experiment
classChanges proposed in this pull request:
__init__
of Experiment so that no_new
method existsExperiment
(started_at
andfinished_at
)@astafan8 @QCoDeS/core