Don't allow connection to db that is newer than the one we support #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen if you go back to an old git version and is dangerous as it can result in inconsistent dbs
Codecov Report
@@ Coverage Diff @@
## master #1454 +/- ##
==========================================
+ Coverage 73.75% 73.76% +0.01%
==========================================
Files 92 92
Lines 10347 10351 +4
==========================================
+ Hits 7631 7635 +4
Misses 2716 2716 |
astafan8
approved these changes
Jan 25, 2019
giulioungaretti
pushed a commit
that referenced
this pull request
Jan 25, 2019
Merge: 7592b40 cf0e532 Author: Jens Hedegaard Nielsen <[email protected]> Merge pull request #1454 from jenshnielsen/dont_connect_to_newer_Db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen if you go back to an old git version and is dangerous
as it can result in inconsistent DBs
I suspect this is the reason why the fix in https://github.com/QCoDeS/Qcodes/blob/master/qcodes/dataset/sqlite_base.py#L2524 has been needed, A db has been upgraded and subsequently written to by an older qcodes version