-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/better parameter docs #1485
Merged
jenshnielsen
merged 16 commits into
microsoft:master
from
jenshnielsen:docs/better_parameter_docs
Feb 21, 2019
Merged
Docs/better parameter docs #1485
jenshnielsen
merged 16 commits into
microsoft:master
from
jenshnielsen:docs/better_parameter_docs
Feb 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: jenshnielsen <[email protected]>
Co-Authored-By: jenshnielsen <[email protected]>
Co-Authored-By: jenshnielsen <[email protected]>
remove out of date comment and direct users of arrayparameter towards parameterwithsetpoints
WilliamHPNielsen
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great improvement. I left a few minor comments.
astafan8
approved these changes
Feb 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #1485 +/- ##
=======================================
Coverage 73.76% 73.76%
=======================================
Files 92 92
Lines 10437 10437
=======================================
Hits 7699 7699
Misses 2738 2738 |
giulioungaretti
pushed a commit
that referenced
this pull request
Feb 21, 2019
Merge: 1029a18 0a266b1 Author: Jens Hedegaard Nielsen <[email protected]> Merge pull request #1485 from jenshnielsen/docs/better_parameter_docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled the improvements to the api docs out of #1478 To make that pr more focused. We can certainly improve these docs further but I think this is already a significant update