Cast array params to np array before inserting #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1497 +/- ##
==========================================
- Coverage 73.78% 73.77% -0.01%
==========================================
Files 92 92
Lines 10439 10440 +1
==========================================
Hits 7702 7702
- Misses 2737 2738 +1 |
astafan8
approved these changes
Mar 1, 2019
jenshnielsen
force-pushed
the
cast_array_params_to_np_array
branch
from
8f7ceea to
58593a3
Compare
jenshnielsen
force-pushed
the
cast_array_params_to_np_array
branch
from
58593a3 to
dd70d11
Compare
|
I believe that coverage drops because https://github.com/QCoDeS/Qcodes/blob/master/qcodes/dataset/measurements.py#L264 is no longer hit (the conversion is now taken care of by atleast_1d) |
giulioungaretti
pushed a commit
that referenced
this pull request
Mar 4, 2019
Merge: 7db6a25 dd70d11 Author: Jens Hedegaard Nielsen <[email protected]> Merge pull request #1497 from jenshnielsen/cast_array_params_to_np_array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise this will not work correctly when inserting as arrays