Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver: ziuhfli - demod{}_harmonic now return int #1534

Merged
merged 6 commits into from
Apr 11, 2019
Merged

Driver: ziuhfli - demod{}_harmonic now return int #1534

merged 6 commits into from
Apr 11, 2019

Conversation

qSaevar
Copy link
Contributor

@qSaevar qSaevar commented Apr 8, 2019

Changes proposed in this pull request:

  • demod{}_harmonic parameters should accept and return ints, not double.

@WilliamHPNielsen @astafan8

@astafan8 astafan8 added the driver label Apr 8, 2019
@astafan8 astafan8 changed the title Feature/dem 515/create instrument adapter for ziuhfli Driver: ziuhfli - demod{}_harmonic now return int Apr 8, 2019
@astafan8 astafan8 added the bug label Apr 8, 2019
@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #1534 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1534   +/-   ##
=======================================
  Coverage   70.52%   70.52%           
=======================================
  Files         103      103           
  Lines       11608    11608           
=======================================
  Hits         8186     8186           
  Misses       3422     3422

@qSaevar
Copy link
Contributor Author

qSaevar commented Apr 11, 2019

@astafan8 can this PR be merged? or is there something I should do?

@astafan8 astafan8 merged commit 51c2683 into microsoft:master Apr 11, 2019
@astafan8
Copy link
Contributor

@qSaevar nope, it's all good, just merged :)

giulioungaretti pushed a commit that referenced this pull request Apr 11, 2019
Merge: c3fdff4 24cf4e2
Author: Mikhail Astafev <[email protected]>

    Merge pull request #1534 from qutech-sd/feature/DEM-515/Create-InstrumentAdapter-for-ZIUHFLI
@qSaevar qSaevar deleted the feature/DEM-515/Create-InstrumentAdapter-for-ZIUHFLI branch April 15, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants