Refactor parameter cache.get #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jenshnielsen
force-pushed
the
rewrite_cache_get
branch
from
b6bf555 to
a833ae0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2008 +/- ##
=======================================
Coverage 71.08% 71.09%
=======================================
Files 145 145
Lines 19467 19478 +11
=======================================
+ Hits 13839 13848 +9
- Misses 5628 5630 +2 |
GateBuilder
approved these changes
May 19, 2020
jenshnielsen
force-pushed
the
rewrite_cache_get
branch
from
03a5e87 to
796222b
Compare
|
@astafan8 I think this should implement the changes we talked about. Do you want to have a look |
4 tasks
astafan8
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This IMHO makes the logic a bit more clear. Functinality it should be the same.
I have changed a case in the if/else statments that should never happen to an error from silently returning a not up to date value.