make it an error to supply get/set_cmd if get/set_raw is not abstract #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
commented
May 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #2015 +/- ##
=======================================
Coverage 71.08% 71.08%
=======================================
Files 145 145
Lines 19463 19467 +4
=======================================
+ Hits 13835 13839 +4
Misses 5628 5628 |
astafan8
approved these changes
May 19, 2020
astafan8
approved these changes
May 19, 2020
jenshnielsen
force-pushed
the
parameter_dont_mix_get_raw_and_get_cmd
branch
from
51ee532 to
065c2e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes no sense to both implement get_raw and supply a get_cmd. Which one should be used. So lets make this an error. There are already 2 subclasses that does the same. DelegateParameter and GroupParameter