B1500: Transient fix for converting str as '-0.-1' to float #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
approved these changes
May 27, 2020
qcodes/instrument_drivers/Keysight/keysightb1500/KeysightB1520A.py
Outdated
Show resolved
Hide resolved
astafan8
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2023 +/- ##
=======================================
Coverage 71.13% 71.13%
=======================================
Files 145 145
Lines 19498 19507 +9
=======================================
+ Hits 13869 13877 +8
- Misses 5629 5630 +1 |
qcodes/instrument_drivers/Keysight/keysightb1500/KeysightB1500_module.py
Outdated
Show resolved
Hide resolved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keysight B1500 responds with a string containing decimal numbers but with signs on both sides of the decimal. For ex: '-0.-1' this PR add function to covert such strings to float.
Once this is fixed in Keysight firmware the commits in this PR can be reverted.