Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group Parameter improvements #2031

Merged
merged 24 commits into from
Jun 4, 2020
Merged

Group Parameter improvements #2031

merged 24 commits into from
Jun 4, 2020

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Jun 3, 2020 •
edited
Loading

Replaces #1995

  • Correctly keeps cache up to date when getting and setting the group parameters
  • Respect mapping between raw_value and value for groupparameters

@codecov
Copy link

codecov bot commented Jun 3, 2020 •
edited
Loading

Codecov Report

Merging #2031 into master will increase coverage by 0.01%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##           master    #2031      +/-   ##
==========================================
+ Coverage   71.16%   71.17%   +0.01%     
==========================================
  Files         149      149              
  Lines       19523    19541      +18     
==========================================
+ Hits        13893    13909      +16     
- Misses       5630     5632       +2

@jenshnielsen
Copy link
Collaborator Author

@lakhotiaharshit and @astafan8 This exposes some inconsitencies in the b15xx drivers especially around the handling of float/int values. After discussing with @lakhotiaharshit I have only done the minimal changes here to fix the tests but it seems likely that more work is needed

astafan8
astafan8 approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to finally clear up this Group implementattion via cache!

@jenshnielsen jenshnielsen merged commit 97f45b4 into microsoft:master Jun 4, 2020
@jenshnielsen jenshnielsen deleted the group-param-cache branch June 4, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lakhotiaharshit lakhotiaharshit lakhotiaharshit left review comments

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenshnielsen @astafan8 @lakhotiaharshit