generate links with a timestamp in the past to avoid collisions #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2038 +/- ##
==========================================
+ Coverage 71.24% 71.31% +0.07%
==========================================
Files 149 149
Lines 19816 19866 +50
==========================================
+ Hits 14117 14167 +50
Misses 5699 5699 |
astafan8
approved these changes
Jun 9, 2020
jenshnielsen
force-pushed
the
genereate_links_in_the_past
branch
from
0f47f0a to
9a8c03a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://travis-ci.com/github/QCoDeS/Qcodes/jobs/346553423 confirms that the issue is indeed due to timestamp collisions so lets ensure that links are generated with a timestamp in the past