Remove deprecated default measurement from station #2058
Conversation
| @@ -242,20 +224,6 @@ def validate_actions(*actions): | |||
| 'objects. `Loop` objects are OK too, except in ' | |||
| 'Station default measurements.') | |||
|
|
|||
| def run(self, *args, **kwargs): | |||
| """ | |||
There was a problem hiding this comment.
Unfortunatly run and run_temp on a loop (as opposed to the activeloop) were not deprecated along with default measurements. They should however not be possible to use without getting a deprecation warning. Should we deprecated these first and then remove or is this fine?
There was a problem hiding this comment.
at a first glance i'd agree with "removing these methods right now in this PR".
at a second glance, i wonder if we can keep these run/run_temp methods - so far as i see in order to do that we need to find a new place for "default measurement", i think a class variable on the Loop class would do the job (and since none of this is documented, i guess, it's not a big deal to implement). Another approach would be to pull the *default into args of the methods. Anyway, of course, the main question is "who will benefit" from keeping these two methods, which i don't have a good answer to.
There was a problem hiding this comment.
ok, read a bit around, ActiveLoop is actually the one that is being "run", so indeed, we can remove these methods safely without breaking anyone's workflows.
There was a problem hiding this comment.
I did actually try putting them on the loop. That works for the 1D case but changes the semantics for the 2d and higher case since it is unclear which of the loops you should bind the default measurements to.
| @@ -242,20 +224,6 @@ def validate_actions(*actions): | |||
| 'objects. `Loop` objects are OK too, except in ' | |||
| 'Station default measurements.') | |||
|
|
|||
| def run(self, *args, **kwargs): | |||
| """ | |||
There was a problem hiding this comment.
ok, read a bit around, ActiveLoop is actually the one that is being "run", so indeed, we can remove these methods safely without breaking anyone's workflows.
jenshnielsen
force-pushed
the
remove_default_measurement
branch
from
37b6aa8 to
b166919
Compare
Codecov Report
@@ Coverage Diff @@
## master #2058 +/- ##
=======================================
Coverage 71.42% 71.42%
=======================================
Files 150 150
Lines 20076 20047 -29
=======================================
- Hits 14339 14319 -20
+ Misses 5737 5728 -9 |
No description provided.