Remove slave master references #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
approved these changes
Jun 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #2066 +/- ##
==========================================
- Coverage 71.40% 71.32% -0.08%
==========================================
Files 150 150
Lines 20047 20008 -39
==========================================
- Hits 14314 14271 -43
- Misses 5733 5737 +4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the use of "slave" as an argument name for a function and as a class name and variable name for magnet power supplies. We have one un-addressed master/slave reference in the code, but that is in
versioneer.py, which should be addressed upstream.I have played it safe by deprecation, but perhaps we can more aggressively simply remove/rename?
@QCoDeS/core