Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix guid tests overwriting home config #2073

Merged

Conversation

jenshnielsen
Copy link
Collaborator

The context manager used to protect the config in the guid tests that overwrites home config was insuffisient as it did not relocate the home config. Use the default_config config manager instead that does this correctly.

In the process of debugging this issue I found that test_generic_formatter cannot be run standalone so fix that too.

Since we use the default_config context manager in multiple locations I also moved that to a common location

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #2073 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2073   +/-   ##
=======================================
  Coverage   71.13%   71.13%           
=======================================
  Files         150      150           
  Lines       20050    20050           
=======================================
  Hits        14263    14263           
  Misses       5787     5787           

@jenshnielsen jenshnielsen merged commit 1b143ef into microsoft:master Jul 6, 2020
@jenshnielsen jenshnielsen deleted the fix_overwriting_home_config branch July 6, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants