Fix guid tests overwriting home config #2073
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context manager used to protect the config in the guid tests that overwrites home config was insuffisient as it did not relocate the home config. Use the default_config config manager instead that does this correctly.
In the process of debugging this issue I found that
test_generic_formatter
cannot be run standalone so fix that too.Since we use the
default_config
context manager in multiple locations I also moved that to a common location