Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook: ParameterWithSetpoints for buffered sweep #2263

Merged

Conversation

jenshnielsen
Copy link
Collaborator

An example of how buffered sweep could be done with parameter with setpoints

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #2263 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2263   +/-   ##
=======================================
  Coverage   71.85%   71.85%           
=======================================
  Files         154      154           
  Lines       20651    20651           
=======================================
  Hits        14838    14838           
  Misses       5813     5813           

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more use-case-driver tutorials - the better :)

Remarks:

  • the notebook lacks description of what it tries to explain, it seems like only people who requested this example will understand it :( Could we a bit more description to the top of the notebook?
  • i think the notebook will read better if DummyArray class is not there, and ParameterWithSetpoints is used explicitly.
  • it's unclear why one would change the setpoints of PwS on the DMM, there's a cell saying "or even change it".

@astafan8 astafan8 added this to the 0.19.0 milestone Oct 14, 2020
@astafan8 astafan8 added the docs Related to docs improvements label Oct 14, 2020
@jenshnielsen jenshnielsen force-pushed the parameter_with_setpoints_example branch from 57adf38 to 8a995f9 Compare October 15, 2020 08:41
@jenshnielsen jenshnielsen merged commit f56a749 into microsoft:master Oct 15, 2020
@jenshnielsen jenshnielsen deleted the parameter_with_setpoints_example branch October 15, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to docs improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants