Station: more useful YAML validation messages #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because this https://github.com/Julian/jsonschema/blob/v3.2.0/jsonschema/exceptions.py#L73 is more useful than .message
those can be potentially very long
Codecov Report
@@ Coverage Diff @@
## master #2282 +/- ##
==========================================
- Coverage 71.85% 71.85% -0.01%
==========================================
Files 154 154
Lines 20655 20651 -4
==========================================
- Hits 14842 14839 -3
+ Misses 5813 5812 -1 |
jenshnielsen
approved these changes
Oct 14, 2020
jenshnielsen
deleted the
astafan8-station-yaml-validation-better-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because this https://github.com/Julian/jsonschema/blob/v3.2.0/jsonschema/exceptions.py#L73 is more useful than
.messageand Dont add full config to station yaml validatior warning message those can be potentially very long.