plotting: don't scale empty units #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2488 +/- ##
=======================================
Coverage 62.31% 62.31%
=======================================
Files 200 200
Lines 26365 26368 +3
=======================================
+ Hits 16429 16431 +2
- Misses 9936 9937 +1 |
i don't know, perhaps we should check with users because if we don't scale, then the values on the axes will become like 2.5e6, right? or will matplotlib nicely put 2.5 on the tick label and 1e6 on a side of the axis? |
trevormorgan
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to me that we should not generate plot labels like.
My label (1*10^6)if the unit is empty.