Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DC bias and measurement time params to Keysight E4980A driver #2502

Merged
merged 18 commits into from
Dec 14, 2020

Conversation

Akshita07
Copy link
Contributor

@Akshita07 Akshita07 commented Dec 8, 2020

Changes proposed in this pull request:

  • Adds DC Bias parameters
  • Adds measurement time parameter
  • Adds method to check installed option number

To Do:

  • Check and add valid voltage range
  • Update meas time parameter (implementation in progress)
  • Test updates on actual instrument

@astafan8

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #2502 (73cdef5) into master (76a0f9a) will decrease coverage by 0.04%.
The diff coverage is 18.51%.

@@            Coverage Diff             @@
##           master    #2502      +/-   ##
==========================================
- Coverage   62.34%   62.30%   -0.05%     
==========================================
  Files         200      200              
  Lines       26379    26404      +25     
==========================================
+ Hits        16447    16450       +3     
- Misses       9932     9954      +22     

@Akshita07 Akshita07 changed the title Add required parameters to Keysight E4980A driver Add DC bias and measurement time params to Keysight E4980A driver Dec 10, 2020
@Akshita07 Akshita07 marked this pull request as ready for review December 11, 2020 13:03
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Just one small question/note, hopefully without the need for any adjustments

@Akshita07 Akshita07 merged commit ab844b6 into microsoft:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants