-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kwarg for experiment id to doNd functions (With tests) #2526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
I wonder if we should also add the "name" kwarg, so that folks can pass a "name" to Measurement which changes the name
of the DataSet. If yes, could be even this PR.
Codecov Report
@@ Coverage Diff @@
## master #2526 +/- ##
=======================================
Coverage 62.32% 62.32%
=======================================
Files 200 200
Lines 26378 26379 +1
=======================================
+ Hits 16440 16441 +1
Misses 9938 9938 |
53e2d96
to
7d5013c
Compare
Replaces #2489 with tests and docstrings included