Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kwarg for experiment id to doNd functions (With tests) #2526

Merged
merged 11 commits into from
Dec 14, 2020

Conversation

jenshnielsen
Copy link
Collaborator

Replaces #2489 with tests and docstrings included

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I wonder if we should also add the "name" kwarg, so that folks can pass a "name" to Measurement which changes the name of the DataSet. If yes, could be even this PR.

@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #2526 (5e1d014) into master (7468aca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2526   +/-   ##
=======================================
  Coverage   62.32%   62.32%           
=======================================
  Files         200      200           
  Lines       26378    26379    +1     
=======================================
+ Hits        16440    16441    +1     
  Misses       9938     9938           

@github-actions github-actions bot merged commit 0ca6a57 into microsoft:master Dec 14, 2020
@jenshnielsen jenshnielsen deleted the dond_exp_arg branch December 14, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants