-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/live plot #270
Merged
Merged
Hotfix/live plot #270
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
078cb25
fix: give MockInstrument a get_idn method so it doesn't complain
alexcjohnson d60b87e
fix: better test for incomplete data rows
alexcjohnson 5b8d972
style: use staticmethod in Formatter where possible
alexcjohnson 7f4eacf
remove unused import
alexcjohnson 8eeac0d
docs: Formatter cleanup
alexcjohnson 249f7a4
docs: the rest of the changes I thought was committing earlier
alexcjohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@giulioungaretti is this a warning you consider worthwhile to include? I suppose we could "fix" it by pulling this function out of the class (bad! makes it harder to read) or probably by turning this into a
@staticmethod
but to me that just seems distracting for not much benefit, so I'd vote to turn this warning off unless you have a strong opinion otherwise.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's super super important actually :D And to suppress the warning with @staticmethod is the way I would go ! It's very pythonic 🐍
For me it's a clear message that the method/function is pure, and has no relation to the state of the object but just a logical relation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can see that argument... for my own part I would have preferred not to introduce a whole new concept (
@staticmethod
) just to signal this, but OK.