avoid loading data twice in to_xarray_dataset #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
approved these changes
Feb 22, 2021
Codecov Report
@@ Coverage Diff @@
## master #2762 +/- ##
==========================================
- Coverage 63.84% 63.84% -0.01%
==========================================
Files 198 198
Lines 26489 26490 +1
==========================================
Hits 16912 16912
- Misses 9577 9578 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to first load the data to verify shape and then reload in _load_to_xarray_dataarray_dict
Fix this by refactoring _load_to_xarray_dataarray_dict to take a loaded dataset