-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve xarray metadata export #3116
Merged
jenshnielsen
merged 10 commits into
microsoft:master
from
jenshnielsen:refine_xarray_export
Jun 11, 2021
Merged
Improve xarray metadata export #3116
jenshnielsen
merged 10 commits into
microsoft:master
from
jenshnielsen:refine_xarray_export
Jun 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jenshnielsen
commented
Jun 11, 2021
•
edited
Loading
edited
- Add units and long_name to match default xarray usage https://xarray.pydata.org/en/stable/getting-started-guide/quick-overview.html#attributes
- Ensure that the per array metadata is also exported to dataarrays (and not just datasets)
- Export parent dataset links
- Tests for all above
- Refactor logic to make the handling of data_vars attrs more clear
Codecov Report
@@ Coverage Diff @@
## master #3116 +/- ##
==========================================
+ Coverage 65.65% 65.67% +0.01%
==========================================
Files 216 216
Lines 28750 28762 +12
==========================================
+ Hits 18877 18889 +12
Misses 9873 9873 |
a4d30fb
to
8bef1e9
Compare
FarBo
reviewed
Jun 11, 2021
astafan8
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.