Fix delegate test #3199
Merged
Fix delegate test #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jenshnielsen
commented
Jul 13, 2021
jenshnielsen
commented
- Test needs an experiment to add data to otherwise it cannot run standalone.
- Test was setting v on a device with non zero post delay and a small step size making it much slower than needed
|
Without this fix the test takes ~ 93 s with it it takes ~ 0.5 s |
Codecov Report
@@ Coverage Diff @@
## master #3199 +/- ##
==========================================
- Coverage 65.90% 65.90% -0.01%
==========================================
Files 218 218
Lines 28888 28888
==========================================
- Hits 19039 19038 -1
- Misses 9849 9850 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.