Feature/multiple validator #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of copying MultiType validator
Merged
| def validate(self, value, context=''): | ||
| super().validate(value=value, context=context) | ||
| if not value % self._divisor == 0: | ||
| raise TypeError('{} is not a multiple of {}; {}'.format( |
There was a problem hiding this comment.
This seems more like a ValueError than a TypeError
There was a problem hiding this comment.
you're right, changing that
alexcjohnson
approved these changes
Sep 22, 2016
There was a problem hiding this comment.
@damazter just one quibble with the type of exception you raised, otherwise this is great. Thanks for the tests! 💃
|
@alexcjohnson |
|
I think the master branch is write protected, I still cannot merge. |
giulioungaretti
pushed a commit
that referenced
this pull request
Sep 22, 2016
Merge: e80f019 5bcce8b Author: alexcjohnson <[email protected]> Merge pull request #339 from qdev-dk/feature/multiple_validator
|
Complexity increasing per file
==============================
- qcodes/tests/test_validators.py 3
Clones added
============
- qcodes/tests/test_validators.py 7
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Add a validator to check if input is a multiple integer of some divisor.
this code was part of #338 but should maybe be part of the qcodes core.
@giulioungaretti
@alexcjohnson