-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMI430: Restore ramp rates of individual magnet axes after simultaneous ramp, for block_during_ramp is True or with call to wait_while_all_axes_ramping #3885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3885 +/- ##
==========================================
+ Coverage 65.80% 66.07% +0.27%
==========================================
Files 228 228
Lines 31129 31147 +18
==========================================
+ Hits 20483 20579 +96
+ Misses 10646 10568 -78 |
jenshnielsen
reviewed
Feb 2, 2022
jenshnielsen
reviewed
Feb 2, 2022
JouriB
approved these changes
Feb 4, 2022
20184c1
to
deecd4d
Compare
abb09d1
to
dd341f6
Compare
jenshnielsen
approved these changes
Feb 16, 2022
… but only if block_during_ramp is True
… but only if block_during_ramp is True for AMI430 IP version
…ly docsrting for ami430 IP version
…ly docsrting for ami430 VISA version
d2c3391
to
840ddfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, it is confusing for users that the
simultaneous
ramp mode does not keep the ramp rate settings of the individual magnet axes intact. User's impression of thesimultaneous
ramp mode with thevector_ramp_rate
parameter is that it sits on top of the individual axes and after the ramp is over, the individual magnet axes should still have their original individual ramp rates preserved.In the implementation,
restore_at_exit
context managers of theramp_rate
parameters are used. The get exit-ed aka closed in thewait_while_all_axes_ramping
, which means that not only users can run the simultanous ramps withblock_during_ramp
isTrue
and the restoring will happen, but also the restoring will happen when users callwait_while_all_axes_ramping
explicitly, even whenblock_during_ramp
is set toFalse
.Credits to @JouriB for the idea and the help with testing, and @jenshnielsen for refining the implementation!