Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public API of logging module #4224

Merged
merged 6 commits into from
Jun 7, 2022
Merged

Conversation

jenshnielsen
Copy link
Collaborator

This defines a public api for the logging module at qcodes.logger and updates examples to use this. Depends on
#4223

@jenshnielsen
Copy link
Collaborator Author

This will generate one-page docs for the logging module like this:

image

The summary is generated by autodocsumm

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #4224 (7733bb7) into master (7733bb7) will not change coverage.
The diff coverage is n/a.

❗ Current head 7733bb7 differs from pull request most recent head 3667ce2. Consider uploading reports for the commit 3667ce2 to get more accurate results

@@           Coverage Diff           @@
##           master    #4224   +/-   ##
=======================================
  Coverage   68.37%   68.37%           
=======================================
  Files         232      232           
  Lines       30860    30860           
=======================================
  Hits        21102    21102           
  Misses       9758     9758           

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors bors bot merged commit 229a7ec into microsoft:master Jun 7, 2022
@jenshnielsen jenshnielsen deleted the public_docs_1 branch June 7, 2022 08:17
bors bot added a commit that referenced this pull request Jun 7, 2022
4230: Build docs with Sphinx 4.5.0 r=jenshnielsen a=jenshnielsen

This tries to fix issue with multiple references in sphinx 4.4.0 and newer by importing fully qualified names. 

In #4224 we use autodocsumm which officially does not support Sphinx 5 so we limit this to Sphinx 4.5 for now

Co-authored-by: Jens H. Nielsen <[email protected]>
bors bot added a commit that referenced this pull request Jun 7, 2022
4237: Create public interface and docs for small modules r=jenshnielsen a=jenshnielsen

This follows a similar pattern to #4224 for the config, math_utils, monitor and station modules. 

Note this does not yet update the example notebooks. 
Since we only have docs for the master branch, I figured it was better to wait with updating the examples till this is in a release

Co-authored-by: Jens H. Nielsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants