Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Make numpyJSONencoder public #4306

Merged
merged 6 commits into from
Jun 23, 2022
Merged

API: Make numpyJSONencoder public #4306

merged 6 commits into from
Jun 23, 2022

Conversation

jenshnielsen
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jun 23, 2022 •
edited
Loading

Codecov Report

Merging #4306 (d7f430d) into master (5437b9c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4306   +/-   ##
=======================================
  Coverage   68.42%   68.42%           
=======================================
  Files         254      255    +1     
  Lines       30967    30972    +5     
=======================================
+ Hits        21188    21193    +5     
  Misses       9779     9779

astafan8
astafan8 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if the encoder is a numpy util, because it takes care of more things than just numpy and the name is "outdated" in that sense, but this place is definitely better than "helpers.py"

@jenshnielsen
Copy link
Collaborator Author

We could also create a json sub module?

@astafan8
Copy link
Contributor

We could also create a json sub module?

yes, that sounds more appropriate. but up to you to decide :)

@jenshnielsen
Copy link
Collaborator Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 23, 2022

Build succeeded:

@bors bors bot merged commit 46d41e6 into microsoft:master Jun 23, 2022
@jenshnielsen jenshnielsen deleted the api/helpers_cleanup branch June 23, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenshnielsen @astafan8